Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SPA script README.md #622

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

OmarAboulMakarem
Copy link

@OmarAboulMakarem OmarAboulMakarem commented Sep 11, 2024

the old script was not working, this script is the one passed to Rails FE and when used in SPA it works

sadly the script only works when i get the correct data-ids from the rails admin script, but it changes dynamically, i dont know how to get the new value everytime

the old script was not working, this script is the one passed to Rails FE and when used in SPA it works
data-html-container="body"
data-hidden-custom-fields></script>
<script
type="text/javascript"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type attribute should be omitted here. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script/type

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your comment but its the same as in the old script in the readme file and i think if you remove it, it will create the MIME type error in the browsers.

also about the data-ids, when i leave it empty it doesnt work, how can i dynamically catch the correct id and place it in it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants