-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marko profile page header responsiveness ( userprofile img, searchbox, connectwallet) #151
base: main
Are you sure you want to change the base?
Conversation
…site into marko-profile-page-responsiveness
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/minorityprogrammers/mpa-webapp/Hg2BAMTUazsZm7qDo4X8APtigoCK |
…ll be called...same functionallity will be called when user clicks with cursor on search icon...(functionallity is added for mobile size screens too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my opinion, the search border color should have a normal color or a dim or different color, then when on focus it should have that purple border color (try adding a little bit of transition as well) , or what do you think??
Also, the font looks too large for a search bar of that width
the color of the placeholder looks like text already. try making it gray or something dim
components/homepage/HomepageNav.js
Outdated
<div style={{border:"1px solid red"}} className="nav__mobile-profile tw:z-10"> | ||
<div style={{border:"1px solid red"}} className="nav__mobile-img"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since you're just adding a border and not manipulating the DOM, why not add it to the className instead, or better still use tailwind, so we can stick to classNames. for consistency. WDYT ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are my oriantation borders, before I was interducing tailwind...I forgot to delete them
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
components/homepage/HomepageNav.js
Outdated
/*router.push({ | ||
pathname: router.pathname, | ||
query: { _q: encodeURI(e.target.value) }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up, if commented out code would not be used in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
solved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool
I think I solved these points...This is a first time using tailwind... |
…screen users and desktop users
Finished: |
Commented the search box-on mobile screens |
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration(if any):
Checklist:
-Edited pull request