Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AmpleMintbase: Milestone 1 submission #156

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

menuRivera
Copy link
Contributor

@menuRivera menuRivera commented Sep 28, 2024

User description

Follow up for AmpleMintbase project


PR Type

documentation, enhancement


Description

  • Added a new submission file for Ample x Mintbase Milestone 1.
  • Included detailed deliverables for the milestone with relevant links.
  • Listed specific modules developed for Mintbase, such as Streaming Royalty Percentage Claims and Gated Streaming Access Module.
  • Provided formatted code guidelines for TypeScript and Rust.

Changes walkthrough 📝

Relevant files
Documentation
AmpleMintbase_milestone1_2024_09_27.md
Added Milestone 1 submission details for Ample x Mintbase project

submissions/AmpleMintbase_milestone1_2024_09_27.md

  • Added a new submission file for Ample x Mintbase Milestone 1.
  • Detailed deliverables for the milestone including links to the main
    repository, license, documentation, testing guide, Docker image, and
    an article with a video.
  • Listed specific modules developed for Mintbase, including Streaming
    Royalty Percentage Claims and Gated Streaming Access Module.
  • Provided formatted code guidelines for TypeScript and Rust.
  • +31/-0   

    💡 PR-Agent usage:
    Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    @mintbase-codium-pr-agent mintbase-codium-pr-agent bot added documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2 labels Sep 28, 2024
    @mintbase-codium-pr-agent
    Copy link

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review

    @mintbase-codium-pr-agent
    Copy link

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Possible issue
    Correct a typo in the TypeScript formatting rules

    Correct the typo in the formatting rules for TypeScript interfaces. Replace
    'PascalCalse' with 'PascalCase'.

    submissions/AmpleMintbase_milestone1_2024_09_27.md [23]

    -3. `PascalCalse` with an `I` for interfaces (like `ISomeInterface`)
    +3. `PascalCase` with an `I` for interfaces (like `ISomeInterface`)
     
    Suggestion importance[1-10]: 9

    Why: The suggestion correctly identifies and fixes a typo in the TypeScript formatting rules, improving the readability and accuracy of the documentation.

    9

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    documentation Improvements or additions to documentation enhancement New feature or request Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants