Fix Env Var Override #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifrel
reviewed
Sep 25, 2023
| config.set_database(connection.to_string()) | ||
| } | ||
| let toml = manual_override(fs::read_to_string(path)?, node_url, db_url)?; | ||
| let config: Config = toml::from_str(&toml.to_string())?; |
There was a problem hiding this comment.
Oh, I didn't know that this would happen. I tried finding the code to circumvent the serialization + deserialization, but it's not too obvious from the toml crate docs.
There was a problem hiding this comment.
It isn't, I was not able to find this yet so at least we have something that works smoothly and looks pretty for now.
There was a problem hiding this comment.
In fact it should just be let config: Config = toml.try_into()?;, but only if toml version is > 0.6.0
There was a problem hiding this comment.
Created an issue here: #12 Will cross reference these comments.
tifrel
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent change in #7 -- introduced an issue Deserializing Config when the expected values were not present.