-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doing price conversions on the SQL-level #84
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks alright to me although its too much to comment on the actual logic. I left a few nits.
count(*), | ||
tx_sender, | ||
timestamp, | ||
a_.nft_contract_id, | ||
kind, | ||
action_sender, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit (indentation):
count(*), | |
tx_sender, | |
timestamp, | |
a_.nft_contract_id, | |
kind, | |
action_sender, | |
count(*), | |
tx_sender, | |
timestamp, | |
a_.nft_contract_id, | |
kind, | |
action_sender, |
amount | ||
from nft_earnings | ||
where is_affiliate = TRUE | ||
and nft_contract_id <> 'deadmau5.mintbase1.near' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This hard coded address seems very specific... was this intended?
-- run manually, depending on mainnet or testnet: | ||
-- insert into currency_conversions values | ||
-- ('ft::usdc.fakes.testnet', 1000000), | ||
-- ('ft::usdt.fakes.testnet', 1000000), | ||
-- ('ft::dac17f958d2ee523a2206206994597c13d831ec7.factory.bridge.near', 1000000), | ||
-- ('ft::a0b86991c6218b36c1d19d4a2e9eb0ce3606eb48.factory.bridge.near', 1000000), | ||
-- ('near', 1000000000000000000000000); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you wanna just leave this out.
-- run manually, depending on mainnet or testnet: | |
-- insert into currency_conversions values | |
-- ('ft::usdc.fakes.testnet', 1000000), | |
-- ('ft::usdt.fakes.testnet', 1000000), | |
-- ('ft::dac17f958d2ee523a2206206994597c13d831ec7.factory.bridge.near', 1000000), | |
-- ('ft::a0b86991c6218b36c1d19d4a2e9eb0ce3606eb48.factory.bridge.near', 1000000), | |
-- ('near', 1000000000000000000000000); |
DO NOT MERGE
This PR will break the FE. We should apply it manually to sandbox, and then the FE can be developed being pointed to that.
This PR