Productionize Request Router

[bh2smith]

This was originally intended for wallet connect but modified/generalized to be used for encoding any types of sign requests following the wallet connect type pattern. intended to be used for the AI CoW Swap Integration (Mintbase/templates#179) - which will require the use of "signTypedData".

cc @microchipgnu

[mintbase-codium-pr-agent]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 PR contains tests

🔒 No security concerns identified

⚡ Key issues to review Error Handling The function requestRouter in src/beta.ts lacks comprehensive error handling for unsupported methods or invalid parameters, which could lead to unhandled exceptions or unclear error messages for the users. Type Checking The isHex function is used in src/beta.ts to check if the transaction parameters are hex encoded, but there's no validation to ensure that the params provided match the expected structure for each method type, which could lead to runtime errors. Function Complexity The requestRouter function in src/beta.ts is quite complex and handles multiple types of requests. Consider refactoring into smaller, more focused functions to improve readability and maintainability.

[mintbase-codium-pr-agent]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Improve type safety by using a type guard for transaction parameters Replace the direct type assertion with a type guard function to ensure the type safety of the tx variable. src/beta.ts [72] -const tx = params[0] as EthTransactionParams; +if (!isEthTransactionParams(params[0])) { + throw new Error("Invalid transaction parameters"); +} +const tx = params[0]; Suggestion importance[1-10]: 9 Why: This suggestion improves type safety by ensuring that params[0] is of the expected type before using it, which can prevent potential runtime errors and improve code reliability.	9
Possible bug	Add checks to ensure params is a non-empty array before accessing its elements Consider checking if params is an array and contains at least one element before accessing params[0] to prevent runtime errors. src/beta.ts [72] +if (!Array.isArray(params) || params.length === 0) { + throw new Error("Parameters must be a non-empty array"); +} const tx = params[0] as EthTransactionParams; Suggestion importance[1-10]: 8 Why: This suggestion adds a necessary check to ensure params is a non-empty array, which can prevent runtime errors when accessing params[0].	8
	Ensure the params array is properly validated to prevent runtime errors Refactor the requestRouter function to handle the case where params might not be provided, to avoid potential runtime errors. src/beta.ts [72] +if (!params || !Array.isArray(params) || params.length === 0) { + throw new Error("Transaction parameters are required and must be an array"); +} const tx = params[0] as EthTransactionParams; Suggestion importance[1-10]: 8 Why: This suggestion ensures that params is properly validated, which can prevent potential runtime errors and improve the robustness of the code.	8
Enhancement	Enhance error messages for unsupported sign methods to improve debugging Use a more specific error message in the exception handling for unsupported sign methods to aid debugging. src/beta.ts [158-160] throw new Error( - `Unsupported sign method ${method}: Available sign methods ${signMethods}` + `Unsupported sign method '${method}'. Supported methods are: ${signMethods.join(", ")}` ); Suggestion importance[1-10]: 7 Why: This suggestion improves the clarity of error messages, making it easier to debug issues related to unsupported sign methods.	7