Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade near-api-js #114

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Upgrade near-api-js #114

merged 2 commits into from
Sep 12, 2024

Conversation

bh2smith
Copy link
Contributor

@bh2smith bh2smith commented Sep 11, 2024

User description

They just released v5.0.0 and none of the breaking changes affected us!

https://github.com/near/near-api-js/releases/tag/near-api-js%405.0.0


PR Type

dependencies, enhancement


Description

  • Upgraded near-api-js dependency from version 4.0.3 to 5.0.0 in package.json.
  • Ensured compatibility with the new version as none of the breaking changes affected the project.

Changes walkthrough 📝

Relevant files
Dependencies
package.json
Upgrade `near-api-js` dependency to v5.0.0                             

package.json

  • Upgraded near-api-js dependency from version 4.0.3 to 5.0.0
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@mintbase-codium-pr-agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@mintbase-codium-pr-agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Best practice
Pin the version of near-api-js to a specific minor version to ensure stability

Consider pinning the version of near-api-js to a specific minor version instead of
using the caret (^) version range. This can help avoid unintentional upgrades that
might introduce breaking changes or bugs due to new versions.

package.json [57]

-"near-api-js": "^5.0.0",
+"near-api-js": "5.0.0",
 
Suggestion importance[1-10]: 9

Why: Pinning the version of near-api-js to a specific minor version can help avoid unintentional upgrades that might introduce breaking changes or bugs due to new versions. This is a best practice for maintaining stability in dependencies.

9

@bh2smith bh2smith merged commit b252353 into main Sep 12, 2024
1 check passed
@bh2smith bh2smith deleted the upgrade-near-api-js branch September 12, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant