fix change pubkey (optimization)

MinterTeam · Sep 28, 2020 · a48d14a · a48d14a
1 parent b0d1d43
commit a48d14a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/core/state/candidates/candidates.go b/core/state/candidates/candidates.go
@@ -1026,9 +1026,7 @@ func (c *Candidates) ChangePubKey(old types.Pubkey, new types.Pubkey) {
 		panic("Candidate with such public key (" + new.String() + ") exists in block list")
 	}
 
-	candidate := c.getFromMap(old)
-	candidate.setPublicKey(new)
-	candidate.setTmAddress()
+	c.getFromMap(old).setPublicKey(new)
 	c.setBlockPubKey(old)
 	c.setPubKeyID(new, c.pubKeyIDs[old])
 	delete(c.pubKeyIDs, old)

diff --git a/core/state/candidates/model.go b/core/state/candidates/model.go
@@ -64,6 +64,7 @@ func (candidate *Candidate) setControl(address types.Address) {
 func (candidate *Candidate) setPublicKey(pubKey types.Pubkey) {
 	candidate.isDirty = true
 	candidate.PubKey = pubKey
+	candidate.setTmAddress()
 }
 
 func (candidate *Candidate) addUpdate(stake *stake) {