Routers #12
Open
Routers #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge length and writing a test in the case of a disconnected graph
yurii-litvinov
suggested changes
Jun 1, 2022
|
|
||
| public class Tests | ||
| { | ||
| IGraph graph = new Graph(); |
There was a problem hiding this comment.
Suggested change
| IGraph graph = new Graph(); | |
| private IGraph graph = new Graph(); |
|
|
||
| using System.Collections.Generic; | ||
|
|
||
| public class Comparator : IComparer<int> |
There was a problem hiding this comment.
Этой штуке тоже нужен комментарий
| /// <summary> | ||
| /// A class for creating custom exceptions | ||
| /// </summary> | ||
| public class DisconnectedGraph : Exception |
There was a problem hiding this comment.
Suggested change
| public class DisconnectedGraph : Exception | |
| public class DisconnectedGraphException : Exception |
Все исключения в .NET именуются с суффиксом Exception
| /// </summary> | ||
| public class DisconnectedGraph : Exception | ||
| { | ||
| public DisconnectedGraph() : base() { } |
There was a problem hiding this comment.
Это можно не писать, оно само сгенерится
| @@ -0,0 +1,44 @@ | |||
| namespace Routers; | |||
|
|
|||
| public interface IGraph | |||
There was a problem hiding this comment.
Интерфейсу тоже нужен комментарий, но я не уверен, что интерфейс нужен вообще
Comment on lines
+233
to
+235
| } | ||
|
|
||
| else |
| { | ||
| ConvertToAnotherDictionary(); | ||
| using StreamWriter writer = new(pathToFile); | ||
| { |
Comment on lines
+274
to
+276
| } | ||
|
|
||
| else |
There was a problem hiding this comment.
Suggested change
| } | |
| else | |
| } | |
| else |
Перед else пустая строка не ставится
| @@ -0,0 +1,35 @@ | |||
| namespace Routers; | |||
|
|
|||
| public class Solution | |||
There was a problem hiding this comment.
А тоже нужен комментарий. А лучше top-level statements
|
|
||
| public class Solution | ||
| { | ||
| static int Main(string[] args) |
yurii-litvinov
suggested changes
Jun 1, 2022
| } | ||
| catch (DisconnectedGraph exception) | ||
| { | ||
| Console.WriteLine($"Error: {exception.Message}"); |
There was a problem hiding this comment.
По условию надо было в поток ошибок писать, тут пишется в stdout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge length and writing a test in the case of a disconnected graph