Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1265: Log bounds applied to twice on joint inversion #645

Merged
merged 10 commits into from
Jan 16, 2024

Conversation

domfournier
Copy link
Contributor

@domfournier domfournier commented Jan 2, 2024

GEOPY-1265 - Log bounds applied to twice on joint inversion

benk-mira
benk-mira previously approved these changes Jan 9, 2024
Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like maybe a duplicate copy operation in there, but otherwise looks good

@domfournier domfournier changed the base branch from release/0.11.0 to develop January 11, 2024 19:26
@domfournier domfournier dismissed benk-mira’s stale review January 11, 2024 19:26

The base branch was changed.

@domfournier domfournier requested a review from benk-mira January 11, 2024 19:34
benk-mira
benk-mira previously approved these changes Jan 12, 2024
@sebhmg sebhmg changed the title GEOPY-1265 GEOPY-1265: Log bounds applied to twice on joint inversion Jan 12, 2024
@domfournier domfournier dismissed benk-mira’s stale review January 12, 2024 22:30

The merge-base changed after approval.

@domfournier domfournier requested a review from benk-mira January 16, 2024 16:46
@domfournier domfournier changed the base branch from develop to release/0.11.1 January 16, 2024 16:57
@domfournier domfournier changed the base branch from release/0.11.1 to develop January 16, 2024 16:58
@domfournier domfournier merged commit 70b6e8b into develop Jan 16, 2024
9 checks passed
@domfournier domfournier deleted the GEOPY-1265 branch January 16, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants