Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GEOPY-1873: geoapps tests are breaking after updating to latest published versions #723

Merged
merged 25 commits into from
Jan 20, 2025

Conversation

domfournier
Copy link
Contributor

@domfournier domfournier commented Jan 15, 2025

GEOPY-1873 - geoapps tests are breaking after updating to latest published versions

benk-mira and others added 19 commits January 9, 2025 11:11
as per instructions of Poetry doc
as notebooks are on LFS, and pre-commit.ci does not support LFS
# Conflicts:
#	.pre-commit-config.yaml
#	docs/conf.py
#	geoapps/base/application.py
#	geoapps/contours/application.py
#	geoapps/contours/constants.py
#	geoapps/contours/driver.py
#	geoapps/contours/params.py
#	geoapps/driver_base/params.py
#	geoapps/edge_detection/application.py
#	geoapps/edge_detection/constants.py
#	geoapps/edge_detection/driver.py
#	geoapps/edge_detection/params.py
#	geoapps/interpolation/driver.py
#	geoapps/inversion/electromagnetics/driver.py
#	geoapps/inversion/utils.py
#	geoapps/iso_surfaces/application.py
#	geoapps/iso_surfaces/constants.py
#	geoapps/iso_surfaces/driver.py
#	geoapps/iso_surfaces/params.py
#	geoapps/shared_utils/utils.py
#	geoapps/triangulated_surfaces/application.py
#	geoapps/utils/plotting.py
#	geoapps/utils/surveys.py
#	pyproject.toml
#	tests/iso_surfaces_test.py
#	tests/utils_test.py
@github-actions github-actions bot changed the title GEOPY-1873 GEOPY-1873: geoapps tests are breaking after updating to latest published versions Jan 15, 2025
@domfournier domfournier requested a review from sebhmg January 15, 2025 22:17
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.

Project coverage is 59.54%. Comparing base (6c4035e) to head (3f61add).
Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
geoapps/base/application.py 66.66% 1 Missing and 1 partial ⚠️
geoapps/base/selection.py 66.66% 2 Missing ⚠️
geoapps/octree_creation/application.py 0.00% 2 Missing ⚠️
geoapps/peak_finder/application.py 33.33% 2 Missing ⚠️
geoapps/utils/models.py 0.00% 2 Missing ⚠️
geoapps/utils/plotting.py 0.00% 2 Missing ⚠️
geoapps/export/application.py 50.00% 1 Missing ⚠️
geoapps/interpolation/application.py 50.00% 1 Missing ⚠️
geoapps/inversion/potential_fields/application.py 0.00% 1 Missing ⚠️
geoapps/triangulated_surfaces/application.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #723      +/-   ##
===========================================
- Coverage    60.61%   59.54%   -1.08%     
===========================================
  Files          101      101              
  Lines         9478     9259     -219     
  Branches      1606     1406     -200     
===========================================
- Hits          5745     5513     -232     
- Misses        3318     3348      +30     
+ Partials       415      398      -17     
Files with missing lines Coverage Δ
geoapps/__init__.py 89.47% <ø> (ø)
geoapps/base/dash_application.py 41.23% <100.00%> (ø)
geoapps/base/layout.py 100.00% <ø> (ø)
geoapps/base/plot.py 78.62% <ø> (ø)
geoapps/block_model_creation/application.py 72.60% <ø> (ø)
geoapps/block_model_creation/constants.py 100.00% <ø> (ø)
geoapps/block_model_creation/driver.py 87.69% <ø> (ø)
geoapps/block_model_creation/layout.py 100.00% <ø> (ø)
geoapps/block_model_creation/params.py 100.00% <ø> (ø)
geoapps/calculator/__init__.py 100.00% <ø> (ø)
... and 91 more

Copy link
Contributor

@benk-mira benk-mira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@domfournier domfournier merged commit 34024d1 into develop Jan 20, 2025
10 checks passed
@domfournier domfournier deleted the GEOPY-1873 branch January 20, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants