Add simplified package checker #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some environments have nodes that start from the similar substring, e.g. ceph001 and ceph-mon01. For this example, the node name is parsed as 'ceph' and 'ceph-mon' correctly. But 'ceph' pcre is used for gathering OSD nodes where ceph001 and ceph-mon001 are grouped togather by mistake. To avoid this, suggest to search with more precise reg.exp.
Fixed Prometheus UI test
Feature/stacklight tests
Avoid wrong node grouping when nodes start from similar substring
The node status in K8S cluster can be "Ready", "NotReady", etc.
If we check the substring "Ready" in "NotReady" status, it can
be found and the test passes. Need to check the entire word "Ready"
in the status field.
Example: test failed on my env:
AssertionError: k8s is not healthy:
"cmp024 NotReady node 103d v1.8.5-4+77af14b530a816",
"cmp046 NotReady node 103d v1.8.5-4+77af14b530a816"
Fixed K8S Node status test
added few ceph tests and empty test files to populate later
|
No objections from my side but one thing - if cloud has no direct access to Mirantis web site do we have any other way to checn package versions? |
vkhalin
reviewed
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.