fix some lint warnings #190
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
crypto/blake2b_test.go#L58
Error return value of `x.Read` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L87
Error return value of `server.ListenAndServe` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L88
Error return value of `node.Loop` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L647
Error return value of `pnode.Loop` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L650
Error return value of `server.ListenAndServe` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L831
Error return value of `server.ListenAndServe` is not checked (errcheck)
|
|
lint:
rpc/consensus_test.go#L832
Error return value of `node.Loop` is not checked (errcheck)
|
|
lint:
command.go#L286
Error return value of `json.Unmarshal` is not checked (errcheck)
|
|
lint:
main.go#L722
Error return value of `http.ListenAndServe` is not checked (errcheck)
|
|
lint:
command.go#L52
use of `fmt.Printf` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
config/reader.go#L14
var-naming: const KernelNetworkId should be KernelNetworkID (revive)
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
common/custodian_test.go#L14
var-naming: const mainnetId should be mainnetID (revive)
|
|
lint:
common/deposit_test.go#L24
var-naming: var chainId should be chainID (revive)
|
|
lint:
common/encoding.go#L207
increment-decrement: should replace off += 1 with off++ (revive)
|