prepare for multiple withdrawal outputs in asset balance calculation #193
cedricfungAnnotations
10 errors and 11 warnings
|
lint:
logger/log.go#L16
logger/log.go:16: Line contains TODO/BUG/FIXME: "FIXME GLOBAL VARIABLES" (godox)
|
|
lint:
logger/log_test.go#L7
import 'github.com/stretchr/testify/require' is not allowed from list 'Main' (depguard)
|
|
lint:
logger/log.go#L19
level is a global variable (gochecknoglobals)
|
|
lint:
logger/log.go#L20
filter is a global variable (gochecknoglobals)
|
|
lint:
logger/log.go#L37
return with no blank line before (nlreturn)
|
|
lint:
logger/log.go#L76
return with no blank line before (nlreturn)
|
|
lint:
logger/log_test.go#L10
Function TestLogger missing the call to method parallel
|
|
lint:
logger/log_test.go#L17
error-nil: use require.NoError (testifylint)
|
|
lint:
logger/log_test.go#L26
error-nil: use require.NoError (testifylint)
|
|
lint:
logger/log_test.go#L37
error-nil: use require.NoError (testifylint)
|
|
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: golangci/golangci-lint-action@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
lint:
crypto/rand.go#L32
increment-decrement: should replace set[b] += 1 with set[b]++ (revive)
|
|
lint:
crypto/blake2b_test.go#L18
unexported-return: exported func NewBlake2bXOF returns unexported type *crypto.xof, which can be annoying to use (revive)
|
|
lint:
crypto/rand.go#L10
unexported-return: exported func RandReader returns unexported type *crypto.randReader, which can be annoying to use (revive)
|
|
lint:
crypto/signature.go#L66
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
crypto/signature.go#L81
receiver-naming: receiver name publicKey should be consistent with previous receiver name privateKey for Key (revive)
|
|
lint:
util/base58/base58check_test.go#L61
redefines-builtin-id: redefinition of the built-in function len (revive)
|
|
lint:
config/reader.go#L14
var-naming: const KernelNetworkId should be KernelNetworkID (revive)
|
|
lint:
storage/interface.go#L33
var-naming: interface method parameter nodeIdWithNetwork should be nodeIDWithNetwork (revive)
|
|
lint:
storage/interface.go#L48
var-naming: interface method parameter nodeId should be nodeID (revive)
|
|
lint:
storage/interface.go#L51
var-naming: interface method parameter nodeId should be nodeID (revive)
|