Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap the domain deposit amount for certain assets #157

Merged
merged 8 commits into from
Oct 12, 2023

Conversation

jadeydi
Copy link
Member

@jadeydi jadeydi commented Mar 7, 2023

No description provided.


switch ver.TransactionType() {
case common.TransactionTypeWithdrawalSubmit:
total = total.Sub(ver.Outputs[0].Amount)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the old data before the deployment, otherwise this integer sub would panic.

@cedricfung
Copy link
Contributor

  1. Test is missing.
  2. A new getasset RPC should be useful.

@cedricfung cedricfung changed the title Feature/asset sum Cap the domain deposit amount for certain assets Oct 12, 2023
@cedricfung cedricfung merged commit 401669c into master Oct 12, 2023
3 checks passed
@cedricfung cedricfung deleted the feature/asset-sum branch October 17, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants