Ensure that required triangles are preserved #274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Explanations of 1.
A bug was introduced by PR #239: triangles required by the user in the input mesh were not preserved anymore.
Indeed, in PR #239, if the face was not
MG_PARALLEL
, then the tagsMG_REQ+MG_SURF
were removed, while onlyMG_SURF
should have been removed if the triangle was initially required by the user.Now, i.e. in this PR, the tag
MG_REQ
of edges is removed only if the edge isMG_PARALLEL
andMG_SURF
.By convention in ParMmg (see tag_pmmg.c in ParMmg), if an entity is
MG_PARBDY+MG_NOSURF+MG_REQ
;MG_PARBDY+MG_REQ
;so we remove the tags
MG_NOSURF
andMG_REQ
only if the edge is effectivelyMG_PARALLEL
and identified asMG_NOSURF
.