Add SwiftLint Plugin #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SwiftLint as a dependency and uses its package plugin.
IIRC, this caused issues previously due to SwiftLint's specification of an untstable version of a dependency, which prevented the specification of a stable version of any package that depended on it. Version
0.54.0(and probably before) only specifies stable versions. Moreover, that wouldn't be an issue for this package anyway as we specify an unstable version ofswift-aws-lambda-runtimesince the last release was nearly a year ago despite significant changes since.Building this with the plugin fails on Linux, presumably because the artifact bundle specified by the plugin only supports macOS. As a result, the plugin is only added to the generic targets when built on macOS.