Add rules_ios example depending on swift_library
#3093
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an example to the rules_ios fixture for showcasing a target merging bug. Reproducing the issue: 1. `cd examples/rules_ios` 2. `bazel run //:xcodeproj-incremental` 3. `xed rules_ios.xcodeproj` 4. Select the `LibTwo_Scheme` target 5. Attempt to build the target 6. Observe the failure: ``` /path/_CompileStub_.m Build input file cannot be found: '/path/_CompileStub_.m'. Did you forget to declare this file as an output of a script phase or custom build rule which produces it? ``` This is happening because in the `LibTwo_Scheme` the target selected is `LibTwo (Static Framework)` when it should be `LibTwo (Library)` which builds fine. This only happens when `swift_library` is directly used as a `deps` of the `apple_framework` target. Target merging fails here and you end up with two `LibTwo` targets in the generated Xcode project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an example to the rules_ios fixture for showcasing a target merging bug.
Reproducing the issue:
cd examples/rules_iosbazel run //:xcodeproj-incrementalxed rules_ios.xcodeprojLibTwo_SchemetargetThis is happening because in the
LibTwo_Schemethe target selected isLibTwo (Static Framework)when it should beLibTwo (Library)which builds fine. This only happens whenswift_libraryis directly used as adepsof theapple_frameworktarget. Target merging fails here and you end up with twoLibTwotargets in the generated Xcode project.