Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added classvar annotations #225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

feldlime
Copy link
Collaborator

@feldlime feldlime commented Dec 7, 2024

Description

  • Added ClassVar annotations

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@feldlime feldlime requested review from blondered and removed request for blondered December 7, 2024 11:36
@feldlime feldlime requested a review from blondered December 7, 2024 11:45
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (49aada9).
Report is 80 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #225     +/-   ##
===========================================
  Coverage   100.00%   100.00%             
===========================================
  Files           45        59     +14     
  Lines         2242      3872   +1630     
===========================================
+ Hits          2242      3872   +1630     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -130,7 +130,7 @@ def __init__(
self.model: LightFM
self._model = model
self.n_epochs = epochs
self.n_threads = num_threads
self.n_threads = num_threads # type: ignore # TODO: remove when recommend n_threads implemented
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's tricky actually. We are using it in LightFM for fit also. Let's please remove this comment here and discuss it in our recommend n_threads PR.
Also it is more menaingfull to move this comment to vector.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants