Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of tz database time zones #147

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Nov 18, 2024

Fixes #146

This PR updates the list of time zones in the schemas (v2.0 to v3.1-RC) with the content of the TZ identifier column from https://en.wikipedia.org/wiki/List_of_tz_zones.

All existing time zones in the schemas were preserved as they all existed in https://en.wikipedia.org/wiki/List_of_tz_zones.

As a result, schemas are more permissive than before and all feeds that were valid are still valid ✅

🇨🇦 For example, 'America/Montreal' is now considered valid by the GBFS JSON Schemas.

@richfab richfab linked an issue Nov 18, 2024 that may be closed by this pull request
@richfab richfab requested a review from davidgamez November 18, 2024 16:56
@richfab richfab merged commit bfa90be into master Nov 18, 2024
1 check passed
@richfab richfab deleted the 146-update-list-of-tz-database-time-zones branch November 18, 2024 16:58
@richfab
Copy link
Contributor Author

richfab commented Nov 18, 2024

@davidgamez What is needed for the GBFS validator to apply these changes?

@richfab
Copy link
Contributor Author

richfab commented Nov 18, 2024

Example of validation with the feed from àVélo Quebec (the time zone 'America/Montreal' should be accepted):
image

@richfab
Copy link
Contributor Author

richfab commented Nov 18, 2024

cc @Alessandro100 who worked on improving the JSON Schema import in the GBFS validator, if I remember correctly.

@davidgamez
Copy link
Member

davidgamez commented Nov 18, 2024

@davidgamez What is needed for the GBFS validator to apply these changes?

We must deploy the GBFS validator as the JSON-schema is packaged during building time.

@richfab
Copy link
Contributor Author

richfab commented Nov 19, 2024

I triggered a "Clear cache and deploy site" on Netlify for the GBFS validator but it's still using the previous version of the JSON Schemas. Can the dev team help please? Thanks! 🙏

@davidgamez
Copy link
Member

I triggered a "Clear cache and deploy site" on Netlify for the GBFS validator but it's still using the previous version of the JSON Schemas. Can the dev team help please? Thanks! 🙏

Sorry, I was not clear enough. We need to deploy using GitHub actions. Let me create a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update list of tz database time zones
2 participants