Add 2.3 typescript models #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hello @uwinkelvos and welcome! Thanks for this very useful contribution 🙏 It is a good decision to use a model as it facilitates migrations and improves data quality. The next step is for our dev team to do the review. We will keep you informed. Additional notes:
Thank you, |
There was a problem hiding this comment.
Great stuff! You'll need to bump the version in the package.json from 1.0.9 to 1.0.10 to trigger publishing to npmjs.com, otherwise it's good to go!
Alessandro100
approved these changes
Jan 23, 2025
richfab
added a commit
that referenced
this pull request
Jan 23, 2025
Follow up of #157 This PR updates the README of the TypeScript model to add v2.3 support.
Alessandro100
added a commit
that referenced
this pull request
Jan 23, 2025
* Add v2.3 support to TypeScript model README Follow up of #157 This PR updates the README of the TypeScript model to add v2.3 support. * updated typescript package --------- Co-authored-by: Alessandro Kreslin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to use the gbfs 2.3 models in a project. As pretty much all necessary things for that are already in place I took the freedom to stick the bits together.