Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates available_until regex to allow timezones #97

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Oct 27, 2023

If you are new to the specification, please introduce yourself (name and organization/link to GBFS). It’s helpful to know who we're chatting with!

MobilityData created this Pull Request on behalf of @hbruch.

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

Fixes #95

available_until is a Datetime which allows timezones but the regex does not accept timezones.

GBFS spec definition:

Datetime (added in v2.3)- Combination of a date and a time following ISO 8601 notation. Attributes : year, month, day, hour, minute, second, and timezone.

What is the proposal?

Update available_until regex to allow timezones.

Before After
image image

Which files are affected by this change?

v2.3/free_bike_status.json and v3.0-RC/vehicle_status.json

@richfab richfab removed the request for review from davidgamez October 27, 2023 14:47
@richfab richfab merged commit 8c3beb1 into master Oct 27, 2023
2 checks passed
@richfab richfab deleted the fix/datetime-regex branch October 27, 2023 15:56
testower added a commit to entur/gbfs-json-schema that referenced this pull request Oct 31, 2023
Updates available_until regex to allow timezones (MobilityData#97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

free_bike_status.available_until datetime regex too restrictive
2 participants