Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 2.3 lyft feeds #538

Closed

Conversation

ArashMansouri
Copy link
Contributor

@ArashMansouri ArashMansouri commented Sep 12, 2023

We're updating the systems.csv files with Lyft's brand new 2.3 GBFS feeds.

Mitch Vars and others added 12 commits January 5, 2022 11:22
Removes references to v3.0, updates README versions table
Adds release date to README for v2.3-RC2
Updates return_constraint to match master
update release candidate dates on README
makes default_pricing_plan_id optional to be non-breaking, corrects errors in code examples, labels new enums
changes to labels and links in prep for 2.3 release
updates to v2.3 tag for v2.3 release
updates version numbers in code examples, corrects boolean types, minor formatting changes
change example station _id from integer to string
@CLAassistant
Copy link

CLAassistant commented Sep 12, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ArashMansouri
❌ Mitch Vars


Mitch Vars seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ArashMansouri ArashMansouri deleted the new-2.3-lyft-feeds branch September 12, 2023 20:27
@futuretap
Copy link
Contributor

@ArashMansouri are you from Lyft? I noticed that in some feeds (Denver, Portland), the last_reported field of the stations in station_status.json is months ago. Is the status information really that old? That would mean the feeds are unusable.

Also, I noticed that the Lyft Washington, DC feed lists vehicle types "1" and "2" in the station_status feed that are not defined in the vehicle_types feed. I assume that this feed is scooter-only and should not include stations at all?

@ArashMansouri
Copy link
Contributor Author

@ArashMansouri are you from Lyft? I noticed that in some feeds (Denver, Portland), the last_reported field of the stations in station_status.json is months ago. Is the status information really that old? That would mean the feeds are unusable.

Also, I noticed that the Lyft Washington, DC feed lists vehicle types "1" and "2" in the station_status feed that are not defined in the vehicle_types feed. I assume that this feed is scooter-only and should not include stations at all?

Hi Ortwin,

Thanks for calling these out. I do work for Lyft and I made a different PR for the update to system.csv so feel free to comment there. For the two points you mentioned, we'll look into this and apply fixes as needed. Thanks!

Arash

@futuretap
Copy link
Contributor

Hi @ArashMansouri, thanks for fixing this issue. We encountered another issue with the Capital Bikeshare feed: In station_status, num_bikes_available is larger than the sum of all vehicle_types_available counts. Specifically, the vehicle_types_available counts are all 0. Also, is the overlap to the Lyft DC feed intentional? The Lyft feed contains the same stations as the CaBi feed, plus the scooter locations in free_bike_status.

@futuretap
Copy link
Contributor

Hi @ArashMansouri the issue with the broken vehicle_types_available persists. Can you please look into this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants