-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Functions python refactoring #850
Open
jcpitre
wants to merge
14
commits into
main
Choose a base branch
from
functions-python-refactoring
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactored the
functions-python
build so it can get packages fromapi/src
and not onlyfunctions-python
folder.Introduced
include_api_folders
in function_config.json to specify the folder from api/src that should be copied to the build. e.g. this was added tobatch_datasets/function_config.json
:Refactored python functions so they can be self-contained, i.e. a functions-python function (e.g.
batch_datasets
) will contain all packages it needs to run and test.batch_datasets
can we loaded directly in the IDE (e.g. Pycharm) and be managed in isolation.To accomplish this, you need to run this:
or
This will create folder
shared
andtest_shared
in the function/src folder. These folders will contain links to the necessary packages.Running
api-tests.sh --folder functions-python
will also callfunction-python-setup.sh
for you before running the tests.This change was done in prevision of #779 that will need packages coming from api/src
Expected behavior:
Build should be the same as before.
tests should run the same as before
Testing tips:
Tested running the
build-tests.yml
action on GH and made sure the tests run properly.Also ran some of the python-functions with function-python-run.sh
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything