-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support latest graph_scheduler #496
Comments
There's a new check for invalid termination condition input, and the two failing tests look to be hitting that. It looks like they don't specify a time scale for the termination condition: Lines 413 to 422 in 2e9cd9c
A correct example: MDF/examples/PsyNeuLink/SimpleFN.json Lines 15 to 27 in 2e9cd9c
In prior graph-scheduler versions, that condition would have been silently ignored. This line looks like the culprit:
|
I'm not sure the exact intent of the model, but my guess would be that termination={"environment_state_update": cond_term}, would be the replacement to make. Maybe @davidt0x has input |
@davidt0x Did you suggest in our last call that your latest PR solved this issue? |
I did suggest that but I forgot to include the fix, will generate another PR, sorry for the confusion. |
This issue is fixed with PR #524 |
Current version only works with graph_scheduler<1.2.0, e.g. see failing tests at:
https://github.com/ModECI/MDF/actions/runs/7739807955
Any idea what's changed in the latest graph_scheduler @kmantel?
The text was updated successfully, but these errors were encountered: