Fix/actr test condition #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specification of termination condition in ACT-R models is breaking with changes to graphscheduler. I have disabled the termination condition specification for now. Examples seem to still run but they are not check outputs so can't say for sure this is the proper fix.
|
Thanks @davidt0x! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #496. The fix is a bit of hack that needs to be investigated further when someone has time to look into ACT-R support more. The way that the importer was specifying termination conditions wasn't compatible with the new version. The termination condition didn't seem to be used in the test examples anyway though.