Adding WeeklyWorkoutActivity. #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
|
|
||
| // val itemList2: ArrayList<YourItem2> = ArrayList() |
There was a problem hiding this comment.
Unused comments please remove
| //import android.view.View | ||
| //import android.view.ViewGroup | ||
| //import android.widget.TextView | ||
| //import androidx.recyclerview.widget.RecyclerView |
| @@ -0,0 +1,3 @@ | |||
| package com.modarb.android.ui.workout.models | |||
|
|
|||
| //data class YourItem2(val textView: String) | |||
There was a problem hiding this comment.
what is the purpose of this class ?
There was a problem hiding this comment.
items type for the second timeline
app/src/main/res/values/strings.xml
Outdated
| @@ -95,5 +95,6 @@ | |||
| <string name="Block1_your_personalized_plan">Block 1 : Your personalized plan</string> | |||
| <string name="Week1_foundation">Week 1 : Foundation</string> | |||
| <string name="Week1_description">Start easy in the first week to let your body get used to the workout. It sets the baseline for your progress in the weeks ahead.</string> | |||
| <string name="Day1_4_Full_body">Day 1 / 4 -Full-body</string> | |||
There was a problem hiding this comment.
use tools instead of creating a string for an initial view that will be replaced by an API response
amrhossamdev
requested changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeline need to edit.