Symbol.for('bar').toString() missing 'bar' (missing [[Description]] value)

[dckc]

Steps to Reproduce

xst -e "print(Symbol.for('bar').toString())"
Symbol()

Expected behavior

Symbol(bar)

Other information

ref https://tc39.es/ecma262/#sec-symbol.prototype.tostring

context: q as best efforts stringify test
https://github.com/endojs/endo/blob/master/packages/ses/test/error/test-assert-log.js#L421
endojs/endo#508

cc @erights @kriskowal

[phoddie]

Interesting find. A quick fix is to modify fxSymbolToString:

void fxSymbolToString(txMachine* the, txSlot* slot)
{
	txSlot* key = fxGetKey(the, slot->value.symbol);
	fxStringX(the, slot, "Symbol(");
	if (key) {
		if ((key->kind == XS_STRING_KIND) || (key->kind == XS_STRING_X_KIND))
			fxConcatStringC(the, slot, key->value.string);
		else if ((key->kind == XS_KEY_KIND) || (key->kind == XS_KEY_X_KIND))
			fxConcatStringC(the, slot, key->value.key.string);
	}
	fxConcatStringC(the, slot, ")");
}

A more careful review and a run through test262 will be needed for a real fix.

[phoddie]

(Apparently test262 didn't report this? If that's true, we should let the maintainers of teset262 know.)

[erights]

Report it at https://github.com/tc39/test262/issues ?

…

On Fri, Apr 2, 2021 at 2:16 PM Peter Hoddie ***@***.***> wrote: (Apparently test262 didn't report this? If that's true, we should let the maintainers of teset262 know.) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#621 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACC3TF6TFEN6M55XZT3TMLTGYX4BANCNFSM42JLG5TA> .

-- Cheers, --MarkM

[dckc]

fix confirmed.

connolly@jambox:~/projects/agoric/endo-mod-up/packages/ses$ yarn test:xs test/error/test-assert-log.js 
yarn run v1.22.0
$ ava-xs test/error/test-assert-log.js
12 tests passed
Done in 1.40s.