Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate XS into SES-shim ci build / test #508

Closed
dckc opened this issue Oct 27, 2020 · 9 comments
Closed

integrate XS into SES-shim ci build / test #508

dckc opened this issue Oct 27, 2020 · 9 comments
Assignees
Labels
kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 xsnap
Milestone

Comments

@dckc
Copy link
Contributor

dckc commented Oct 27, 2020

briefly...

Agoric/agoric-sdk#1649 https://github.com/Agoric/agoric-sdk/blob/master/packages/xs-vat-worker/Makefile and see the submodule in https://github.com/Agoric/agoric-sdk/tree/master/packages/xs-vat-worker

@kriskowal had a less than enthusiastic reply to the submodule approach

there's also the issue of doing this on macos, possibly using docker...

cc @warner @erights

@dckc
Copy link
Contributor Author

dckc commented Jan 25, 2021

The xsnap package opens up other approaches to this.

ref Agoric/agoric-sdk#2194 , Agoric/agoric-sdk#2225

see also #535

@dckc
Copy link
Contributor Author

dckc commented Apr 5, 2021

I got a pass over the SES test suite running...

83 tests passed
16 tests failed

48 test scripts SKIPped for various reasons

details:
https://gist.github.com/dckc/75663ff47b714f4dbf10ecf6dd1f602c

cc @erights @kriskowal @warner @michaelfig

@dckc
Copy link
Contributor Author

dckc commented Apr 10, 2021

current status: 82bc8eb

91 tests passed
58 tests failed

22 scripts skipped:

  • 7: babel
  • 1: import.meta.url
  • 14: boring errors/ dir

details: https://gist.github.com/dckc/83bdc1a4febf4f5eed4b7f9f08097f61

@dckc
Copy link
Contributor Author

dckc commented Apr 10, 2021

115 tests pass; 0 fail; 40 scripts SKIPped as of c61a2e9

I'm starting to feel pretty good about SES tests on XS. SKIPs are due to:

In some cases, several tests in a script should work on XS but the mechanism for excluding is at the whole script level.

details: https://gist.github.com/dckc/ecdcc72e0537ad069033b4f37ba1e90b
https://github.com/endojs/endo/tree/535-ava-xs

@rowgraus
Copy link

rowgraus commented May 7, 2021

@dckc to check with @erights on the timeline for this. Is it required prior to the Stress Test phase in 3 weeks?

@dckc
Copy link
Contributor Author

dckc commented May 7, 2021

@kriskowal @warner finishing this involves making some decision on how to organize xsnap #681 ; ideally, producing something usable both for endo / ses testing and for agoric-sdk.

I sure don't want to destabilize the xsnap in agoric-sdk just now... so the question of when is tricky.

@kriskowal
Copy link
Member

I’m closing this as a duplicate of #812 to be addressed by #1847

@kriskowal
Copy link
Member

Reöpening because #1847 doesn’t address XS installation in CI. Tracking that here.

@kriskowal kriskowal reopened this Jan 10, 2024
@kriskowal kriskowal added kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds labels Jan 10, 2024
@kriskowal
Copy link
Member

kriskowal commented Sep 25, 2024

Endo has CI for SES that verifies that Lockdown runs to completion on XS #2465, #2259, and more to come in #2259 persuant to #400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kriskowal-just-do-it-2024-01 Tasks that kriskowal can close out quickly to clear weeds kriskowal-review-2024-01 Issues that kriskowal wants to bring to the attention of the team for review as of January, 2024 xsnap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants