Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

[WIP] Upgrade to Modus-React #214

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[WIP] Upgrade to Modus-React #214

wants to merge 2 commits into from

Conversation

grgur
Copy link
Member

@grgur grgur commented Jan 7, 2019

#213 Work in progress: use Modus-React scaffolding

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 29823 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Jan 7, 2019

Code Climate has analyzed commit 825ff84 and detected 0 issues on this pull request.

View more on Code Climate.

@@ -96,6 +101,7 @@
},
"dependencies": {
"@babel/runtime-corejs2": "^7.0.0",
"@modus/more": "0.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, npm i fails here:

npm ERR! 404 Not Found: @modus/[email protected]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emimuresan can you try manually with

npm i @modus/more --registry=https://npm.modus.app/ 

This package is in our private registry for now. I'm surprised package-lock didn't pick that up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants