DEVELOP-721: removing checkqc threshold check (#55)

* DEVELOP-721: removing checkqc threshold check * DEVELOP-721: Updated unit tests
Molmed · Mar 6, 2024 · d88e32b · d88e32b
1 parent d37769f
commit d88e32b
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/bin/get_qc_config.py b/bin/get_qc_config.py
@@ -31,11 +31,6 @@ def __init__(self):
                 multiqc_mapping="percent_Q30",
                 compare_direction="lt",
             ),
-            ValueHandlerMapper(
-                handler_name="ReadsPerSampleHandler",
-                multiqc_mapping="mqc-generalstats-bcl2fastq-total",
-                compare_direction="lt",
-            ),
         ]
 
         self.mapping = self._convert_to_mappings(self._mapper_list)

diff --git a/tests/unit_tests/test_get_qc_config.py b/tests/unit_tests/test_get_qc_config.py
@@ -75,6 +75,5 @@ def test_convert_to_multiqc_config(checkqc_config_dict):
     multiqc_config = convert_to_multiqc_config(checkqc_config_dict)
     multiqc_section = multiqc_config["table_cond_formatting_rules"]
     assert multiqc_section["Error"]["warn"] == [{"gt": 2}]
-    assert multiqc_section["mqc-generalstats-bcl2fastq-total"]["fail"] == [{"lt": 13.5}]
     assert multiqc_section["percent_Q30"]["warn"] == [{"lt": 80}]
     assert multiqc_section["total"]["warn"] == [{"lt": 18}]