Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit tests #60

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improve unit tests #60

wants to merge 2 commits into from

Conversation

jgostylo
Copy link

There are several structural changes that I am submitting.

  • Use of snapshots: To prevent cross contamination of tests through residual effects there is now a snapshot that is reverted in the highest level beforeEach and afterEach
  • The setup of the Baal contract is now handled either in the tests for the constructor tests or in beforeEach of the other tests. This is to allow for additional constructor testing and to be more explicit on setups.
  • Adding some configurations for fail constructor cases
  • Extracting the setup of the Baal initialization into functions to allow setup to be controlled by parameters. Now tests can choose a setup state and failure configurations can be tested.

dekanbro pushed a commit that referenced this pull request Sep 12, 2022
@brossetti1
Add name sigs (#60)
54a1dbf 
* add name to delegate sig

* adding token name to vote

* bump version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jgostylo