Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #71

Merged
merged 22 commits into from
Feb 8, 2024
Merged

Fix CI #71

merged 22 commits into from
Feb 8, 2024

Conversation

Fancy2209
Copy link
Contributor

@Fancy2209 Fancy2209 commented Feb 6, 2024

I'm sorry for the issues

  • Remove macOS14 Runner (LibreSSL is conflicting with OpenSSL on build)
  • Disable macOS 12 Unit Tests (I cannot fix this as I do not have a mac or the necessary knowledge)
  • Fix the Unit Tests Command on Windows
  • Fix Install Paths for MonaBase and MonaCore
  • Fix Linux Binaries the libs to the right place

@Fancy2209
Copy link
Contributor Author

Fancy2209 commented Feb 6, 2024

I had to disable UnitTests on mac, who isn't good because I've had a person have issues on Mac, I unfortunately have no idea why they weren't working, will try to fix them on a separate PR (though that might make it fail)

@Fancy2209
Copy link
Contributor Author

OH
it passes CI now, it just doesn't show logs

@Fancy2209
Copy link
Contributor Author

YES!
It works now

@Fancy2209
Copy link
Contributor Author

Fancy2209 commented Feb 6, 2024

I asked someone to test
It tries to load the libraries from where they were on the macOS Runner, I'm not sure how to fix that. On windows they seem to be compiled in the final executable

@Fancy2209
Copy link
Contributor Author

Fancy2209 commented Feb 6, 2024

Same issue on linux
./MonaServer: error while loading shared libraries: libMonaBase.so: cannot open shared object file: No such file or directory

@thomasjammet
Copy link
Contributor

Hi Fancy, thanks for the fixes!

It just misses the ../MonaBase/lib/libMonaBase.so and ../MonaCore/lib/libMonaCore.so libraries, can you include it inside the artifact? Same problem for MacOS

LibreSSL is conflicting with OpenSSL => something to check so, I guess everyone will get the issue.

@Fancy2209
Copy link
Contributor Author

Fancy2209 commented Feb 7, 2024

Hi Fancy, thanks for the fixes!

It just misses the ../MonaBase/lib/libMonaBase.so and ../MonaCore/lib/libMonaCore.so libraries, can you include it inside the artifact? Same problem for MacOS

LibreSSL is conflicting with OpenSSL => something to check so, I guess everyone will get the issue.

It's only happening on MacOS 14 (LibreSSL I mean)
Also I think the macOS Port just is not working properly too. I've had someone try to host a RTMFP Server and connect and it failed

@Fancy2209
Copy link
Contributor Author

Fancy2209 commented Feb 7, 2024

This is done! (everything I can do at least)
I do not have a mac to fix the macOS Unit Tests
thanks @bugaevc for telling me how to fix the macOS Binary Build Path!

@MathieuPOUX
Copy link
Contributor

Thanks really for your contribution @Fancy2209 !! It looks me good to merge, good for you too @thomasjammet ?

@thomasjammet
Copy link
Contributor

Thanks really for your contribution @Fancy2209 !! It looks me good to merge, good for you too @thomasjammet ?

Thanks Fancy, I think it's ok, can you just remove linux binaries from git?

@Fancy2209
Copy link
Contributor Author

Thanks really for your contribution @Fancy2209 !! It looks me good to merge, good for you too @thomasjammet ?

Thanks Fancy, I think it's ok, can you just remove linux binaries from git?

I thought I hadn't committed those, ups!
Will fix asap

@thomasjammet thomasjammet merged commit 13b4eb4 into MonaSolutions:master Feb 8, 2024
3 checks passed
@thomasjammet
Copy link
Contributor

Thanks for the last fixes! I can't tell about the macos part because unfortunately I don't have a way to test it right now.

About linux part it was not working, it is something I already experienced, by default RPATH is changed to RUNPATH and is using absolute path. You can check with :
objdump -p ./MonaServer

@Fancy2209
Copy link
Contributor Author

Thanks for the last fixes! I can't tell about the macos part because unfortunately I don't have a way to test it right now.

About linux part it was not working, it is something I already experienced, by default RPATH is changed to RUNPATH and is using absolute path. You can check with : objdump -p ./MonaServer

Ah thanks, I also don't have a mac btw, I was using darlinghq to check if the dylibs loaded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants