-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: release fixes #86
base: main
Are you sure you want to change the base?
refactor: release fixes #86
Conversation
justinngan92
commented
Apr 24, 2024
- remove Get_rendering module
- update usage of vfo module in docs and code
- remove Get_rendering module - update usage of vfo module in docs and code
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
- Coverage 87.30% 86.80% -0.50%
==========================================
Files 16 16
Lines 4522 4571 +49
==========================================
+ Hits 3948 3968 +20
- Misses 574 603 +29
|
* add transient analysis options
dda7dee
to
4f3a0f6
Compare
@justinngan92 can you check this PR and rebase onto #74 please? |
- remove Get_rendering module - update usage of vfo module in docs and code
* add transient analysis options
* extracts velocity and accelerations
Thanks @justinngan92 . Can you explore the reason for the tests failing please? Do these changes mean the tests need to be updated or are there bugs in the changes? |
bbf0651
to
bf0af9e
Compare
@justinngan92 Yes, for now we may need to change the requirement to numpy ~= 1.26 so that all tests pass and we can solve the other issues. Afterwards, we should then work on adapting the code to be valid for numpy 1.x and 2.x if possible. |
6bb9f95
to
bf0af9e
Compare
* resolve compatibility issue with numpy 2.0