Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: release fixes #86

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

justinngan92
Copy link
Collaborator

  • remove Get_rendering module
  • update usage of vfo module in docs and code

- remove Get_rendering module
- update usage of vfo module in docs and code
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 47.43590% with 41 lines in your changes missing coverage. Please review.

Project coverage is 86.80%. Comparing base (cc0fb4a) to head (3e1776a).
Report is 4 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   87.30%   86.80%   -0.50%     
==========================================
  Files          16       16              
  Lines        4522     4571      +49     
==========================================
+ Hits         3948     3968      +20     
- Misses        574      603      +29     
Files Coverage Δ
src/ospgrillage/__init__.py 100.00% <100.00%> (ø)
src/ospgrillage/mesh.py 91.42% <100.00%> (-0.01%) ⬇️
src/ospgrillage/postprocessing.py 89.11% <100.00%> (-0.08%) ⬇️
src/ospgrillage/utils.py 88.85% <ø> (ø)
tests/test_load.py 100.00% <100.00%> (ø)
tests/test_osp_grillage.py 97.02% <ø> (ø)
src/ospgrillage/members.py 78.44% <66.66%> (-0.50%) ⬇️
src/ospgrillage/osp_grillage.py 80.67% <31.03%> (-1.53%) ⬇️

... and 3 files with indirect coverage changes

@justinngan92 justinngan92 changed the title refactor: prep release fixes refactor: release fixes Apr 24, 2024
@ccaprani
Copy link
Member

@justinngan92 can you check this PR and rebase onto #74 please?

@ccaprani
Copy link
Member

Thanks @justinngan92 . Can you explore the reason for the tests failing please? Do these changes mean the tests need to be updated or are there bugs in the changes?

@justinngan92
Copy link
Collaborator Author

@ccaprani Its because the test suites use numpy 2.0. I think its changing the requirement to <2.0 here should work?

@ccaprani
Copy link
Member

@justinngan92 Yes, for now we may need to change the requirement to numpy ~= 1.26 so that all tests pass and we can solve the other issues. Afterwards, we should then work on adapting the code to be valid for numpy 1.x and 2.x if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants