feat: add podcast list and spotify embedded #369
Conversation
|
@kanhaiya88628 more than requested time already assigned. |
kanhaiya88628
force-pushed
the
podcastStyle
branch
from
4b687ca to
1626f94
Compare
There was a problem hiding this comment.
- remove the podcast navigate button from the expression page.
- on clicking seeAll it should redirect to first podcast page, which is presently redirecting to the sportify.
- add a little space between the play button and the podcast title.
- In the podcast page add next and previous text with the navigate button.
- remove the podcast placeholder file.
- undo the changes made in getSpotifyAccessToken.js file after finishing all your work.
- change title of the pull request.
| @@ -1,7 +1,7 @@ | |||
| const getSpotifyAccessToken = async () => { | |||
| try { | |||
| const { access_token } = await fetch( | |||
| process.env.NODE_ENV === 'production' | |||
| process.env.NODE_ENV !== 'production' | |||
There was a problem hiding this comment.
@kanhaiya88628 why this change committed
kanhaiya88628
changed the title
kanhaiya88628
changed the title
| @@ -30,7 +30,7 @@ function Expressions({ | |||
| miscellaneous, | |||
| }) { | |||
| const classes = useStyles(); | |||
|
|
|||
| const hidePagination = true; | |||
| @@ -70,7 +70,9 @@ function Expressions({ | |||
| { | |||
| name: 'Podcasts', | |||
| container: true, | |||
| section: <PodcastList spotify={spotify} />, | |||
| section: ( | |||
| <PodcastList spotify={spotify} hidePagination={hidePagination} /> | |||
There was a problem hiding this comment.
@kanhaiya88628 no need create a variable directly use the required value i.e hidePagination={false}
There was a problem hiding this comment.
@kanhaiya88628 no need create a variable directly use the required value i.e hidePagination={false}
It is not working while declaring in this way
|
@kanhaiya88628 sync the code with the latest changes. |
There was a problem hiding this comment.
@kanhaiya88628 in previous first add icon then text and in next first text and then logo.
In first and last page button should be disabled not hidden.
There was a problem hiding this comment.
expression subcategory page in getStaticPaths function add a filter function in paths to remove podcast page.
| const len = isNextNull.length; | ||
|
|
There was a problem hiding this comment.
@kanhaiya88628 add a null check here using chaining operator
|
@kanhaiya88628 next and previous button is not deactivated at the beginning and at the end of the list. When a user clicks the next button when the list ends it shows the error page.
|
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Linked Issues
Fixes #354
Description
Please describe your pull request.
❤️Thank you!
Post merge checklist