Various fix for no_dereferencing context manager #2788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…referencing correctly in some cases + fix tests
bagerard
force-pushed
the
fix_no_dereference_swallowing_errors
branch
from
a935dc1 to
a9285ef
Compare
bagerard
force-pushed
the
fix_no_dereference_swallowing_errors
branch
from
a9285ef to
40dde29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__exit__swallowing the exception) ...as it was useless and making it look like it was returning a different class.
This means it is now just
with no_dereferencing(User):instead ofwith no_dereferencing(User) as OtherUserClass:Fixes #2504