Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding white + navy blue dress #5029

Merged

Conversation

ThePotatoGuy
Copy link
Member

@ThePotatoGuy ThePotatoGuy commented Nov 22, 2019

#4550

Key changes

  • White and Navy Blue dress with bunny scrunchie from @Velius94
  • bunny-scrunchie ACS type with template. muxable with ribbons
  • the bunny-scrunchie also only works with non-twintail ribbon hairs
  • _acs_wear_if_gifted - only wears an ACS if it has been gifted/reacted to
  • Exprops now will have constants in mas_sprites. we'll do this on a rolling basis. I need to update the wiki first.
  • the hair tie selector now filters hair ties based on the current hair. This means no single-sided ACS (the bunny scrunchie, black bow) when wearing a twin-tail hair style
  • ponytail-braid hair style no longer has the twintails prop

New exprop

  • excluded-hair-props - value should be a list of hair props that are in compatible with this ACS

TODO

  • thumbs
  • select dlg if desired
  • dlg-desc
  • determine what the blue ribbon thing is. We can't really use Ribbon (Blue) because it looks different than the normal ribbons.

Testing

  • verify that the clothes + acs look good
  • in outfit mode, the clothes will swap to a ribbon + non-twintails hair style to wear the bunny scrunchie.
  • verify the bunny scrunchie and black bow cannot be worn with a twintail hair style
  • verify the hair tie selector does not list bunny scrunchie or blackbow if a twintail hair style is worn

@ThePotatoGuy ThePotatoGuy added awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested DONT MERGE srs labels Nov 22, 2019
@ThePotatoGuy ThePotatoGuy added this to the 0.10.4 milestone Nov 22, 2019
@ThePotatoGuy ThePotatoGuy removed the DONT MERGE srs label Dec 3, 2019
@ThePotatoGuy
Copy link
Member Author

@MisterSimple @Legendkiller21 this has been updated with the decided ACS name

@multimokia multimokia removed awaiting dlg review dialogue needs to be reviewed awaiting testing code needs to be tested labels Dec 5, 2019
@multimokia multimokia merged commit 218c3e5 into Monika-After-Story:content Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants