Fix error NU5030: The license file 'LICENSE' does not exist in the package. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckage. Context https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5030#issue When the filename of the license file has no extension NuGet reports an error. ``` error NU5030: The license file 'LICENSE' does not exist in the package. ``` Even though we have the `PackagePath` set. According to the error page, the `PackagePath` in these cases should be empty. To fix this we need to split out the `LicenceName` tag into two values so that they can be set independently. So we add `LicenceNamePackagePath` tag so that we can do so. Existing code should behave the same way.
harry-cpp
reviewed
Feb 23, 2024
Tasks/PublishPackageTask.cs
Outdated
| else | ||
| projectData = projectData.Replace("{LicenceName}", "LICENSE"); | ||
| projectData = projectData.Replace("{LicenceName}", "LICENSE").Replace ("{LicencePackagePath}", "LICENSE"); |
There was a problem hiding this comment.
Shouldn't LicencePackagePath be set to "" here as well?
There was a problem hiding this comment.
else if (context.PackContext.LicensePath.EndsWith ("LICENSE")) becomes redundant if true so it can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://learn.microsoft.com/en-us/nuget/reference/errors-and-warnings/nu5030#issue
This has come up with the Assimp repository https://github.com/MonoGame/MonoGame.Library.Assimp.
When the filename of the license file has no extension NuGet reports an error.
Even though we have the
PackagePathset. According to the error page, thePackagePathin these cases should be empty.To fix this we need to split out the
LicenceNametag into two values so that they can be set independently. So we addLicenceNamePackagePathtag so that we can do so. Existing code should behave the same way.