Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc reviews #21

Conversation

MrValentine7777
Copy link

I give up with this pull request thing, I cannot make sense why I have other PRs to seek through to find my file so I have no idea what is going on, I thought creating the sub module as requested was to mitigate those issues... :( let me know if this makes any sense...

MrValentine7777 and others added 4 commits May 30, 2024 11:12
…ect commit

Updated the `.gitignore` file to include the `/external/MonoGame` directory. Enhanced the `HowTo_ChangePitchAndVolume.md` file with updated instructions for playing a sound and adjusting its pitch and volume, including a new method `IsKeyPressed(Keys key)`. Added code in the `Game.Update` method to adjust the pitch and volume of the sound effect when the **Space** key is pressed. The pitch and volume values are increased by +0.1f each time the **Space key** is pressed and are clamped to ensure they are within valid ranges. Added notes explaining the use of the `MathHelper.Clamp` method and the potential issue of the keypress check not preventing the method from repeating. Updated the copyright year in the `HowTo_ChangePitchAndVolume.md` file from 2023 to 2024. Removed a subproject commit in the MonoGame project.
This commit primarily focuses on enhancing code readability and providing more detailed documentation. Key changes include the use of bold formatting for key terms and method names, addition of explanatory notes and tips, inclusion of using statements and field declarations at the top of the file/class, and a new method to check key press status. A caution note about file name and location usage, a note about sound status, and an extended example for pitch and volume adjustment have also been added. Comments have been inserted in the code for better understanding of certain operations. Lastly, some method names have been replaced with their bold counterparts for consistency and readability.
@SimonDarksideJ SimonDarksideJ changed the base branch from main to feature/docsmigration May 30, 2024 14:38
@SimonDarksideJ
Copy link
Collaborator

No changes

@SimonDarksideJ SimonDarksideJ deleted the DocReviews branch May 30, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants