Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of unfinished PlayerDamageKeeperand new Macro for Nerve Functions #18

Open
wants to merge 38 commits into
base: master
Choose a base branch
from

Conversation

Trippixyz
Copy link
Contributor

@Trippixyz Trippixyz commented Jan 22, 2024

PlayerDamageKeeper:

  • Adds 3 function declarations: activatePreventDamage, dead and damage.

NerveSetupUtil:

  • New Macro to better define so called "Actions" (Nerve Functions) for both the definition and declaration.

This change is Reviewable

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Trippixyz)


lib/al/include/Library/Nerve/NerveSetupUtil.h line 41 at r1 (raw file):

#define NERVE_MAKE(Class, Action) Class##Nrv##Action Action;

#define NERVE_FUNC(Action) void exe##Action()

Sounds sensible to me that the devs had a macro like this, do you think we should put this as a discussion on the modding server again to see how others feel about moving the functions to a bunch of macros?

Copy link
Contributor Author

@Trippixyz Trippixyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)


lib/al/include/Library/Nerve/NerveSetupUtil.h line 41 at r1 (raw file):

Previously, MonsterDruide1 wrote…

Sounds sensible to me that the devs had a macro like this, do you think we should put this as a discussion on the modding server again to see how others feel about moving the functions to a bunch of macros?

Yes we should get some more opinion on this! I'll post this on the modding server.

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @Trippixyz)


.github/workflows/compile-check.yml line 7 at r2 (raw file):

  compile_verify:
    runs-on: ubuntu-latest
    environment: PRs-allow-ExeFS

Please remove this again, should work with the normal workflows now - if you rebase your PR.


lib/al/include/Library/Nerve/NerveSetupUtil.h line 41 at r1 (raw file):

Previously, Trippixyz wrote…

Yes we should get some more opinion on this! I'll post this on the modding server.

I guess that's enough of a positive answer - no one seriously protested, so I see that as "accepted".

@MonsterDruide1
Copy link
Owner

Bumping this, you'd only need to remove the PR workflow stuff again and rebase to hopefully get everything sorted!

GRAnimated and others added 20 commits June 24, 2024 15:29
…FollowCamera`, `EffectObjFollowCameraLimit`, `EffectObjFunction` and `EffectObjInterval` (MonsterDruide1#128)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants