Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom linter: add many new checks and features #260

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

LynxDev2
Copy link
Contributor

@LynxDev2 LynxDev2 commented Jan 12, 2025


This change is Reviewable

@MonsterDruide1
Copy link
Owner

Please fix clang-format and the missing functions first.

@LynxDev2 LynxDev2 force-pushed the format-checker-fixes branch from 12a2bfb to a40b4a4 Compare January 13, 2025 09:56
@LynxDev2
Copy link
Contributor Author

Done

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 39 of 50 files at r1, all commit messages.
Reviewable status: 39 of 50 files reviewed, 12 unresolved discussions (waiting on @LynxDev2)


src/System/GameDataFile.cpp line 8 at r1 (raw file):

// NON_MATCHING

No empty line


lib/al/Library/Execute/ExecuteDirector.cpp line 111 at r1 (raw file):

// NON_MATCHING

(same)


lib/al/Library/Rail/RailRider.cpp line 8 at r1 (raw file):

// NON_MATCHING

No empty line


lib/al/Library/Math/MathRandomUtil.cpp line 46 at r1 (raw file):

// NON_MATCHING

No empty line


src/Player/PlayerInput.cpp line 0 at r1 (raw file):
Keep type of inputPort consistent (either u32 or s32)


lib/al/Library/Rail/Rail.cpp line 70 at r1 (raw file):

}

// (NON_MATCHING) FIXME: minor reorderings

Remove FIXME tags, having NON_MATCHING is enough
(same for all other FIXMEs below)

Suggestion:

// NON_MATCHING: minor reorderings

src/Npc/AchievementInfoReader.cpp line 10 at r1 (raw file):

// NON_MATCHING: minor mismatches during loop

No empty line


src/Player/PlayerJudgePreInputJump.cpp line 25 at r1 (raw file):

// NON_MATCHING

No empty line


src/Player/PlayerInputFunction.cpp line 7 at r1 (raw file):

// NON_MATCHING

No empty line


src/Player/PlayerPainPartsKeeper.cpp line 76 at r1 (raw file):

// NON_MATCHING

No empty line


lib/al/Library/Controller/InputFunction.cpp line 607 at r1 (raw file):

// NON_MATCHING

No empty line between comment and function


src/Player/PlayerModelHolder.cpp line 10 at r1 (raw file):

// NON_MATCHING

No empty line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants