-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom linter: add many new checks and features #260
base: master
Are you sure you want to change the base?
Conversation
Please fix |
12a2bfb
to
a40b4a4
Compare
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 39 of 50 files at r1, all commit messages.
Reviewable status: 39 of 50 files reviewed, 12 unresolved discussions (waiting on @LynxDev2)
src/System/GameDataFile.cpp
line 8 at r1 (raw file):
// NON_MATCHING
No empty line
lib/al/Library/Execute/ExecuteDirector.cpp
line 111 at r1 (raw file):
// NON_MATCHING
(same)
lib/al/Library/Rail/RailRider.cpp
line 8 at r1 (raw file):
// NON_MATCHING
No empty line
lib/al/Library/Math/MathRandomUtil.cpp
line 46 at r1 (raw file):
// NON_MATCHING
No empty line
src/Player/PlayerInput.cpp
line 0 at r1 (raw file):
Keep type of inputPort
consistent (either u32
or s32
)
lib/al/Library/Rail/Rail.cpp
line 70 at r1 (raw file):
} // (NON_MATCHING) FIXME: minor reorderings
Remove FIXME
tags, having NON_MATCHING
is enough
(same for all other FIXME
s below)
Suggestion:
// NON_MATCHING: minor reorderings
src/Npc/AchievementInfoReader.cpp
line 10 at r1 (raw file):
// NON_MATCHING: minor mismatches during loop
No empty line
src/Player/PlayerJudgePreInputJump.cpp
line 25 at r1 (raw file):
// NON_MATCHING
No empty line
src/Player/PlayerInputFunction.cpp
line 7 at r1 (raw file):
// NON_MATCHING
No empty line
src/Player/PlayerPainPartsKeeper.cpp
line 76 at r1 (raw file):
// NON_MATCHING
No empty line
lib/al/Library/Controller/InputFunction.cpp
line 607 at r1 (raw file):
// NON_MATCHING
No empty line between comment and function
src/Player/PlayerModelHolder.cpp
line 10 at r1 (raw file):
// NON_MATCHING
No empty line
const
references (Fixes Custom linter: References should always beconst
#70)auto
(Fixes Custom linter: Disallow raw usage ofauto
, only allowauto&
andauto*
#68)char16_t
(Fixes Custom linter: Enforcechar16_t
->char16
from sead types #118)NON_MATCHING
comment above non-matching functions #71, opt-in with --check-mismatch but used automatically for the linter job)--all
for running all checks even if some failed (Resolves Custom linter: Let custom linter run all checks even if the check before failed. #95)--run-clang-format
for runningclang-format
automatically before checking each file (Resolves Custom linter: Run standardclang-format
before #79)--run-clang-format
isn't used (--no-warn
for disabling this for the linter job)--verbose
optionattackSensor
andreceiveMsg
to haveself
andother
param names.0f
is enforced and.f
disallowed but this might be reversed after discussion)This change is