-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapObj: Implement CoinCollectHintObj
#267
MapObj: Implement CoinCollectHintObj
#267
Conversation
e3648db
to
e037454
Compare
CoinCollectHintObj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @german77)
src/Item/CoinCollectHolder.h
line 26 at r1 (raw file):
void registerHintObj(CoinCollectHintObj*); bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const;
Suggestion:
CoinCollect* tryFindAliveCoinCollect(const sead::Vector3f&, bool) const;
src/Item/CoinCollectHolder.h
line 27 at r1 (raw file):
bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect(const sead::Vector3f&, f32, f32, bool) const;
Suggestion:
CoinCollect* tryFindAliveCoinCollect(const sead::Vector3f&, f32, f32, bool) const;
src/Item/CoinCollectHolder.h
line 28 at r1 (raw file):
bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect(const sead::Vector3f&, f32, f32, bool) const; bool tryFindDeadButHintEnableCoinCollect() const;
Suggestion:
CoinCollect* tryFindDeadButHintEnableCoinCollect() const;
src/Item/CoinCollectHolder.h
line 30 at r1 (raw file):
bool tryFindDeadButHintEnableCoinCollect() const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, f32, f32, bool) const;
Suggestion:
CoinCollect2D* tryFindAliveCoinCollect2D(const sead::Vector3f&, bool) const;
CoinCollect2D* tryFindAliveCoinCollect2D(const sead::Vector3f&, f32, f32, bool) const;
src/Item/CoinCollectHolder.h
line 31 at r1 (raw file):
bool tryFindAliveCoinCollect2D(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, f32, f32, bool) const; bool tryFindExStageHintObjTrans(sead::Vector3f*, const char*);
Suggestion:
CoinCollectHintObj* tryFindExStageHintObjTrans(sead::Vector3f*, const char*);
e037454
to
e14e883
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 5 unresolved discussions (waiting on @MonsterDruide1)
src/Item/CoinCollectHolder.h
line 26 at r1 (raw file):
void registerHintObj(CoinCollectHintObj*); bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const;
Done.
src/Item/CoinCollectHolder.h
line 27 at r1 (raw file):
bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect(const sead::Vector3f&, f32, f32, bool) const;
Done.
src/Item/CoinCollectHolder.h
line 28 at r1 (raw file):
bool tryFindAliveCoinCollect(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect(const sead::Vector3f&, f32, f32, bool) const; bool tryFindDeadButHintEnableCoinCollect() const;
Done.
src/Item/CoinCollectHolder.h
line 31 at r1 (raw file):
bool tryFindAliveCoinCollect2D(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, f32, f32, bool) const; bool tryFindExStageHintObjTrans(sead::Vector3f*, const char*);
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, 5 unresolved discussions (waiting on @MonsterDruide1)
src/Item/CoinCollectHolder.h
line 30 at r1 (raw file):
bool tryFindDeadButHintEnableCoinCollect() const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, bool) const; bool tryFindAliveCoinCollect2D(const sead::Vector3f&, f32, f32, bool) const;
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @german77)
This one required more code in the header than the implementation. Is used in CoinCollectHolder.
This change is