Library/Nature: Implement WaterSurfaceFinder
#317
+120
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetraxile
reviewed
Jan 29, 2025
There was a problem hiding this comment.
unfortunate :( i wasn't able to make it any better either. hopefully someone will figure this out
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)
lib/al/Library/Nature/WaterSurfaceFinder.cpp line 17 at r1 (raw file):
// NON_MATCHING: storing {0,0,0} if no surface was found (https://decomp.me/scratch/zHEdm) void WaterSurfaceFinder::updateLocal(const sead::Vector3f& position, const sead::Vector3f& gravity, f32 distance, bool flat, bool displacement, bool overGround) {
should these names begin with an is? as in, isFlat, isDisplacement, isOverGround?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small helper class to locate the nearest water surface looking down from the given actor. Sadly, because
updateLocalis not matching, none of the other functions for updating the result matches either.https://decomp.me/scratch/zHEdm
This change is