Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player: Implement PlayerAnimFrameCtrl #318

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MonsterDruide1
Copy link
Owner

@MonsterDruide1 MonsterDruide1 commented Jan 27, 2025

This class is used to keep track of the current frame within an animation. It can handle looping animations (mIsActionRepeat) and changing the framerate of animations (mRate), resulting in faster or slower playback.


This change is Reviewable

@MonsterDruide1 MonsterDruide1 self-assigned this Jan 27, 2025
Copy link
Contributor

@tetraxile tetraxile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MonsterDruide1)


src/Player/PlayerAnimFrameCtrl.h line 31 at r1 (raw file):

    f32 mRate = 1.0f;
    bool mIsSkipUpdate = false;
};

add static_assert for size of struct here

Copy link
Owner Author

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tetraxile)


src/Player/PlayerAnimFrameCtrl.h line 31 at r1 (raw file):

Previously, tetraxile wrote…

add static_assert for size of struct here

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants