Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library/MapObj: Implement SupportFreezeSyncGroupHolder #320

Merged

Conversation

Fuzzy2319
Copy link
Contributor

@Fuzzy2319 Fuzzy2319 commented Jan 28, 2025

This PR adds SupportFreezeSyncGroupHolder functions.


This change is Reviewable

Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Fuzzy2319)


lib/al/Library/MapObj/SupportFreezeSyncGroupHolder.cpp line 8 at r1 (raw file):

namespace al {
// NON_MATCHING: It doesn't seems to be a for loop but I don't know this pattern.

lib/al/Library/MapObj/SupportFreezeSyncGroupHolder.cpp line 21 at r1 (raw file):

    initActorPoseTRSV(this);

    LiveActor::initHitSensor(1);

Suggestion:

initHitSensor(1);

Copy link
Contributor Author

@Fuzzy2319 Fuzzy2319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MonsterDruide1)


lib/al/Library/MapObj/SupportFreezeSyncGroupHolder.cpp line 8 at r1 (raw file):

namespace al {
// NON_MATCHING: It doesn't seems to be a for loop but I don't know this pattern.

Oops I thought I deleted this comment.

Done.


lib/al/Library/MapObj/SupportFreezeSyncGroupHolder.cpp line 21 at r1 (raw file):

    initActorPoseTRSV(this);

    LiveActor::initHitSensor(1);

Done.

@Fuzzy2319 Fuzzy2319 force-pushed the SupportFreezeSyncGroupHolder branch from 0708e51 to 98a2f13 Compare January 29, 2025 11:20
Copy link
Owner

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Fuzzy2319)

@MonsterDruide1 MonsterDruide1 merged commit 6395d28 into MonsterDruide1:master Feb 1, 2025
6 checks passed
@Fuzzy2319 Fuzzy2319 deleted the SupportFreezeSyncGroupHolder branch February 1, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants