Skip to content

Commit

Permalink
revert fadeToBlackBy optimization
Browse files Browse the repository at this point in the history
causes problems with overlay text (scrolling text)
  • Loading branch information
softhack007 committed Aug 8, 2024
1 parent 6e415df commit 90dd048
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion wled00/FX_fcn.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1473,7 +1473,8 @@ void __attribute__((hot)) Segment::fadeToBlackBy(uint8_t fadeBy) {
for (int y = 0; y < rows; y++) for (int x = 0; x < cols; x++) {
uint32_t cc = getPixelColorXY(x,y); // WLEDMM avoid RGBW32 -> CRGB -> RGBW32 conversion
uint32_t cc2 = color_fade(cc, scaledown); // fade
if (cc2 != cc) setPixelColorXY((uint16_t)x, (uint16_t)y, cc2); // WLEDMM only re-paint if faded color is different
//if (cc2 != cc) // WLEDMM only re-paint if faded color is different - disabled - causes problem with text overlay
setPixelColorXY((uint16_t)x, (uint16_t)y, cc2);
}
} else {
for (uint_fast16_t x = 0; x < cols; x++) {
Expand Down

0 comments on commit 90dd048

Please sign in to comment.