Audiosync espnow #148
Audiosync espnow #148
Conversation
| @@ -960,17 +967,6 @@ class AudioReactive : public Usermod { | |||
| int8_t mclkPin = MCLK_PIN; | |||
| #endif | |||
| #endif | |||
| // new "V2" audiosync struct - 40 Bytes | |||
There was a problem hiding this comment.
@netmindz something is strange with your PR - this a very old definition of audioSyncPacket, also I'm missing some other new features that were added in the last 4 months.
might be better if you make a fresh branch from mdev and drop your changed file into the latest codebase 🤔
| @@ -1834,7 +1816,19 @@ class AudioReactive : public Usermod { | |||
| DEBUGSR_PRINTLN(F("AR connected(): old UDP connection closed.")); | |||
| } | |||
|
|
|||
| if (audioSyncPort > 0 && (audioSyncEnabled & 0x03)) { | |||
There was a problem hiding this comment.
this line looks different now
WLED/usermods/audioreactive/audio_reactive.h
Lines 2110 to 2112 in d255bec
| @@ -442,7 +446,7 @@ void FFTcode(void * parameter) | |||
| // taskYIELD(), yield(), vTaskDelay() and esp_task_wdt_feed() didn't seem to work. | |||
|
|
|||
| // Don't run FFT computing code if we're in Receive mode or in realtime mode | |||
| if (disableSoundProcessing || (audioSyncEnabled & 0x02)) { | |||
| if (disableSoundProcessing || (audioSyncEnabled == 2) || (audioSyncEnabled == 4)) { | |||
There was a problem hiding this comment.
instead of using "4", i'd suggest to add something like this
#define AUDIOSYNC_SEND_ESPNOW 0x09 // UDP sound sync - 9 = send by ESP_NOW
#define AUDIOSYNC_REC_ESPNOW 0x0A // UDP sound sync - 10= receive by ESP_NOW
#define AUDIOSYNC_REC_ESPNOW 0x0D // UDP sound sync - 14= receive-or-local by ESP_NOW
Or even simpler, let's add another variable bool audioSyncUseESPNOW; to indicate that ESP-NOW is used instead of UDP multicast.
Edit: I thing the second option is better.
And I won't cry about another byte of RAM used while there are still spare bits around somewhere 😉
| @@ -928,6 +928,7 @@ build_flags_S = | |||
| lib_deps_S = | |||
| ;; https://github.com/kosme/arduinoFFT#develop @ 1.9.2+sha.419d7b0 ;; used for USERMOD_AUDIOREACTIVE - using "known working" hash | |||
| https://github.com/softhack007/arduinoFFT.git#develop @ 1.9.2 ;; used for USERMOD_AUDIOREACTIVE - optimized version, 10% faster on -S2/-C3 | |||
| https://github.com/RobTillaart/[email protected] | |||
There was a problem hiding this comment.
better add this to AR_lib_deps
Line 1022 in d255bec
just make a second line so it looks like this
AR_lib_deps =
https://github.com/softhack007/arduinoFFT.git#develop @ 1.9.2 ;; used for USERMOD_AUDIOREACTIVE - optimized version, 10% faster on -S2/-C3
https://github.com/RobTillaart/[email protected] ;; provides a running average filter
There was a problem hiding this comment.
edit: need to think about this filter - it looks rather complicated maybe i can give you an easier "home-brew" one that serves the same purpose.
|
Sorry @softhack007 - I didn't mean for you to look at this just yet. The branch is very old so I need to update and fix the conflicts etc before it's ready to be looked at |
@netmindz no problem :-) actually its good to see an early preview 👍 , so I can make upfront recommendations instead of changing everything late in the process. |
|
I'd accidentally made the PR inside my own fork rather than into MoonModules last year |
No description provided.