Quick experiment to expand frequency range #167
Draft
+31
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softhack007
reviewed
Sep 24, 2024
|
|
||
| static uint8_t getMax(uint8_t* myArray) { | ||
| uint8_t maxV = 0; | ||
| for (int i = 0; i < (sizeof(myArray) / sizeof(myArray[0])); i++) { |
There was a problem hiding this comment.
This is a rather tricky pitfall in C - if you pass an array pointer, sizeof() behaves differently and you cannot get the number of array items. It means that sizeof(myArray) = 4 (size of a pointer) so the loop will always run over exactly 4 elements.
There was a problem hiding this comment.
I hate C arrays 😉 Thanks for the tip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reference, this is what the effect looked like originally deliberately without serpentine correction
https://photos.app.goo.gl/6Zkw4ckXqApmFdWD8