Skip to content

Commit

Permalink
dlt-hub#814 Clean up grammar
Browse files Browse the repository at this point in the history
Signed-off-by: Marcel Coetzee <[email protected]>
  • Loading branch information
Pipboyguy committed Dec 16, 2023
1 parent bd37f9f commit 04c8ffc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions dlt/common/storages/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ class FilesystemConfiguration(BaseConfiguration):
}

bucket_url: str = None
# should be an union of all possible credentials as found in PROTOCOL_CREDENTIALS
# should be a union of all possible credentials as found in PROTOCOL_CREDENTIALS
credentials: FileSystemCredentials

@property
Expand All @@ -112,7 +112,7 @@ def on_resolved(self) -> None:
"File path or netloc missing. Field bucket_url of FilesystemClientConfiguration"
" must contain valid url with a path or host:password component."
)
# this is just a path in local file system
# this is just a path in a local file system
if url.path == self.bucket_url:
url = url._replace(scheme="file")
self.bucket_url = url.geturl()
Expand All @@ -124,9 +124,7 @@ def resolve_credentials_type(self) -> Type[CredentialsConfiguration]:

def fingerprint(self) -> str:
"""Returns a fingerprint of bucket_url"""
if self.bucket_url:
return digest128(self.bucket_url)
return ""
return digest128(self.bucket_url) if self.bucket_url else ""

def __str__(self) -> str:
"""Return displayable destination location"""
Expand Down
2 changes: 1 addition & 1 deletion dlt/common/storages/fsspec_filesystem.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def fsspec_filesystem(
def fsspec_from_config(config: FilesystemConfiguration) -> Tuple[AbstractFileSystem, str]:
"""Instantiates an authenticated fsspec `FileSystem` from `config` argument.
Authenticates following filesystems:
Authenticates the following filesystems:
* s3
* az, abfs
* gcs, gs
Expand Down

0 comments on commit 04c8ffc

Please sign in to comment.