Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 修复LockScroll后切换页面无法滚动 #478

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

Moonofweisheng
Copy link
Owner

@Moonofweisheng Moonofweisheng commented Jul 31, 2024

Closes: #473

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

#473

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新特性
    • 引入了新的生命周期钩子,增强了 useLockScroll 的功能,确保在组件卸载或停用时适当释放滚动锁定。
  • 性能改进
    • 优化了资源管理,封装了清理过程,改进了锁定机制的控制流,确保组件生命周期事件的正确响应。

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 3:47pm

Copy link

coderabbitai bot commented Jul 31, 2024

Walkthrough

此次更改增强了 useLockScroll 组合函数的功能,通过引入 onBeforeUnmountonDeactivated 生命周期钩子,确保在组件卸载或停用时调用 destroy 函数。这一改动改进了资源管理,实现了在页面切换时恢复滚动状态,从而解决了未关闭弹窗时无法滚动的问题。

Changes

文件 修改摘要
src/uni_modules/wot-design-uni/components/composables/useLockScroll.ts 引入生命周期钩子(onBeforeUnmountonDeactivated),确保在组件停用或卸载时调用 destroy 函数以释放滚动锁定。

Assessment against linked issues

Objective Addressed Explanation
在页面切换或组件卸载时恢复滚动状态 (#473)
解决未关闭弹窗时导致的页面无法滚动问题 (#473)

Poem

🐰 在草地上欢跳乐,
弹窗关闭复滚动,
生命周期真神奇,
清理资源谢天地!
感谢代码美好更,
小兔子舞翩翩! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for wot-design-uni ready!

Name Link
🔨 Latest commit 5933673
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66aa5c9618f72600088a2d3b
😎 Deploy Preview https://deploy-preview-478--wot-design-uni.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (1)
src/uni_modules/wot-design-uni/components/composables/useLockScroll.ts (1)

22-24: 确保destroy函数逻辑正确

destroy函数在组件停用或卸载时调用,确保滚动锁定状态正确释放。逻辑上没有问题,但建议在注释中说明其用途,以提高代码可读性。

+  // 在组件停用或卸载时调用,确保滚动锁定状态正确释放
  const destroy = () => {
    shouldLock() && unlock()
  }
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 84826f8 and 5933673.

Files selected for processing (1)
  • src/uni_modules/wot-design-uni/components/composables/useLockScroll.ts (2 hunks)
Additional comments not posted (2)
src/uni_modules/wot-design-uni/components/composables/useLockScroll.ts (2)

30-31: 验证生命周期钩子的使用

新增的onDeactivatedonBeforeUnmount生命周期钩子确保在组件停用或卸载时调用destroy函数。此改动符合预期,确保资源管理得当。


32-34: 确保返回正确的方法

返回的lockunlock方法确保了外部调用的灵活性。代码逻辑清晰,符合预期。

@Moonofweisheng Moonofweisheng merged commit 197d61a into master Aug 1, 2024
7 checks passed
@Moonofweisheng Moonofweisheng deleted the fix-lockscroll branch August 1, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

h5使用弹窗且未关闭,切换页面(tabbar)或返回上一页,导致页面无法滚动
1 participant